custom shader parameters in 1.7.2

General Discussion
1

So I’ve been away from panda for a couple months, and I’ve come to find the latest version has broken my shaders. Everything works fine in 1.7.1, but in 1.7.2 I get these errors.

:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in sampler2d detailTexture)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in sampler2d texUnit0)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in float4 region0Limits)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in sampler2d texUnit1)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in float4 region1Limits)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in sampler2d texUnit2)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in float4 region2Limits)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in float4 region3Limits)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in sampler2d texUnit3)
:gobj(error): shaders/stephen6.sha: invalid parameter name (uniform in float4 region4Limits)

Do I have to go back to using the “k” prefix or something? I’m not sure what’s going on here.

2

Does it work in the buildbot release? An earlier buildbot release incorrectly called itself version 1.7.1, even though it actually contained code from the 1.8 branch, which has been causing confusion.

David

3

Prefix the parameters with the k_ prefix in the shader code (not in the Python code).

Like:
uniform in float4 k_region0Limits

4

Actually it works fine with a daily build now. 1.7.1 and the current repository seem to both work. Just 1.7.2 seems to be the issue. I’m content to use the daily build though. Thanks guys.