openCVTexture

Compiling or Editing the Panda Source
1

Hi,

My compiler complains (now that I make everything instead of excluding all kinds of modules via --no-xxx switches to makepanda) about the following and I have to agree:

in openCVTexture.h we see these method declarations:

virtual bool do_read_one(
 const Filename &fullpath, 
 const Filename &alpha_fullpath,
 int z, 
 int n, 
 int primary_file_num_channels, 
 int alpha_file_channel);

 virtual bool do_load_one(
 const PNMImage &pnmimage, 
 const string &name,
 int z, 
 int n);

while in openCVTexture.cxx, line 300, we see this definition:

bool OpenCVTexture::
do_read_one(
 const Filename &fullpath, 
 const Filename &alpha_fullpath,
 int z, 
 int n, 
 int primary_file_num_channels, 
 int alpha_file_channel,
 BamCacheRecord *record)

How could this ever work?

Now what I’ll locally do is simply add the missing parameter to the first overload declaration, but I’d rather see that solved in CVS.

Thanks a lot,
Max Hajek

2

Ah, a fine example of bit-rot. We didn’t notice because we’re not compiling OpenCVTexture anymore in the VR Studio; that class is now deprecated in favor of FFMpegTexture.

I’ll check in the obvious fix. Thanks for pointing it out.

David