1.7.1 release

rdb · March 9, 2011, 1:32pm

OK, new debs are up. They have the nvidia-cg-toolkit dependency fixed, and the p3d tools included.
They also accidentally include a fix for shadow samplers in shaders. This was a bug introduced by CMU students; I had checked in a fix before, but I forgot to pick up that fix for 1.7.1. So it’ll be properly in 1.7.2.

upperBound · March 9, 2011, 3:03pm

rdb:

So basically, if I understand this correctly: it should pass None instead of _xwindow, like:
if (glxgsg->_context == NULL) {
  glXMakeCurrent(_display, None, NULL);
} else {
  glXMakeCurrent(_display, _xwindow, glxgsg->_context);
}
Can you verify if that works? I don’t have a Panda3D installation with X11 handy.

I posted the same question on MESA forum. To me it seems like a bug in the MESA code. I will let you know when I hear back from them.

Also, I will try your suggestion and, again, will let you know.

UB

ynjh_jo · March 9, 2011, 6:08pm

Was it this bug (advanced one) ?
:display:gsg:glgsg(error): GL texture creation failed for : invalid operation
:display:gsg:glgsg(error): Could not load

And this one is still crashing hard (tested on windows) :

from pandac.PandaModules import *
#~ loadPrcFileData('','notify-level-display spam')
from direct.showbase.DirectObject import DirectObject
import direct.directbase.DirectStart

class World( DirectObject ):

  def __init__( self ):
#     base.disableMouse()
    base.cam.setPos( 0, -20, 2 )
#     self.accept( 'mouse1', self.destroyAndCreate )
    render.setShaderAuto()
    self.create()

  def create( self ):
    self.rootNode = render.attachNewNode( 'rootNode' )
    CM = CardMaker('')
    CM.setFrame(-1,1,-1,1)
    card = self.rootNode.attachNewNode( CM.generate())
    card.setZ(-1)
    card.setScale(5)
    card.setP(-90)

    self.light = self.rootNode.attachNewNode( Spotlight( 'Spot' ) )
    self.lightNode = self.light.node()
    self.lightNode.setShadowCaster( True, 512, 512 )
    self.light.setPos( -20, -20, 20 )
    self.light.lookAt( 0,0,0 )
    self.light.posInterval(3,Point3(-30,-20,20)).loop()
    self.rootNode.setLight( self.light )

    loader.loadModel( 'teapot' ).reparentTo( self.rootNode )

    self.buffer = base.win.makeTextureBuffer( 'Buffer', 512, 512 , Texture())
    self.camNP = base.makeCamera( self.buffer )
    self.camNP.reparentTo( self.rootNode )

  def destroy( self ):
    self.buffer.clearRenderTextures()
    #~ self.buffer.setActive(0)
    #~ print self.buffer.getDisplayRegion(0).getCamera()
    base.graphicsEngine.removeWindow( self.buffer )
    self.camNP = self.buffer = None
    taskMgr.doMethodLater(.5,self.postDestroy,'postDestroy')

  def postDestroy(self,t):
    self.lightNode.setShadowCaster( False )
    self.rootNode.clearLight( self.light )
    self.light = None
    self.rootNode.setState(RenderState.makeEmpty())
    self.rootNode.setShaderOff(10)
    self.rootNode.removeNode()
    print base.graphicsEngine.getNumWindows()
    base.bufferViewer.refreshReadout()

  def destroyAndCreate( self ):
    self.destroy()
    self.create()

w = World()

import os
base.accept('escape',os._exit,[0])
base.accept('space',w.destroy)
base.accept('enter',w.create)

base.bufferViewer.enable(1)
run()

Press SPACE, then ENTER.

And thanks for the hard work !

rdb · March 9, 2011, 6:21pm

Nah, it was a compile error for shaders that use sampler2dShadow parameters.

Could you file a bug report on launchpad for that one?

upperBound · March 9, 2011, 6:35pm

upperBound:

rdb:
So basically, if I understand this correctly: it should pass None instead of _xwindow, like:
if (glxgsg->_context == NULL) {
  glXMakeCurrent(_display, None, NULL);
} else {
  glXMakeCurrent(_display, _xwindow, glxgsg->_context);
}
Can you verify if that works? I don’t have a Panda3D installation with X11 handy.
I posted the same question on MESA forum. To me it seems like a bug in the MESA code. I will let you know when I hear back from them.

Also, I will try your suggestion and, again, will let you know.

UB

Following up…

MESA developers suggested a patch and it got rid of the SEGFAULT. Unfortunately, even with the patch the 1.7.1 Roaming-Ralph gives a black window with lots of X11 errors in the console.

My gut feeling is something broke in 1.7.1.

I am reverting back to 1.7.0. I will try to dig in more if I find time.

UB

rdb · March 9, 2011, 7:16pm

For the record, could you give me a link to the relevant forum topic?

upperBound · March 9, 2011, 7:43pm

If you mean the MESA forum it is:

http://lists.freedesktop.org/archives/mesa-dev/2011-March/005908.html

zoiba · March 10, 2011, 7:27pm

my game game won’t run anymore on v.1.7.1, it seems the problem is the dot operation, so, I made a test file trying to isolate the problem.

this is the test script I used:

from pandac.PandaModules import * 
import direct.directbase.DirectStart
from direct.showbase.DirectObject import DirectObject
class test(DirectObject):

	def __init__(self):
		cp1 = VBase3(1,1,1)
		cp2 = VBase3(1,1,1)
		print cp1.dot(cp2)
w=test()

run()

running it by typing python main.py it prints 3.0 on console and opens the panda3d window, that’s ok.
I used packp3d to pack the application and things go wrong when running the packaged application. The application exits with errors. The key error messages are:
[cut]
print cp1.dot(cp2)
TypeError: ‘libpanda.VBase3’ object is not callable
[cut]

have I found a bug?

Best regards

ThomasEgi · March 10, 2011, 7:53pm

someone on irc experinced the same problem with an arm build. it works ok for me tho. 64bit lucid.

zoiba · March 11, 2011, 6:52pm

at the end I solved the dot operation trouble by writing my own dot function.
here the code in case somebody needs it:

def dot(cp1, cp2):
	x = cp1.getX()*cp2.getX()
	y = cp1.getY()*cp2.getY()
	z = cp1.getZ()*cp2.getZ()
	return x+y+z

Best regards

rdb · March 11, 2011, 8:13pm

OK, I know what’s going on with the vector mess. It was a treacherous NDEBUG ifdef in the getattr method.

I’ll update the runtime.panda3d.org packages tomorrow. As it only occurs during the runtime, it’s not worth making a 1.7.2 right away for, but it’s important enough to have it fixed really soon.

I haven’t debugged the pdeploy issue with makensis yet, but it’s high on my priority list too, and I will get that fixed really soon, or at least implement the hacky workaround that I know will work.

drwr: do you have any thoughts on the glXMakeCurrent issue? Looking at the spec, it seems to me that we’re misusing it anyway when we’re releasing the context. I could be entirely wrong, though.

Sorry for the inconveniences.

drwr · March 11, 2011, 9:26pm

I think your proposed fix, to pass None as the Window parameter, is the right thing to do. Is there a different problem that you see in addition to this?

david

rdb · March 12, 2011, 2:38pm

I’ve just updated the packages at runtime.panda3d.org, the vector issue should be fixed now.

It also has the updated pdeploy.p3d, with the fixes for nsis. It turns out that subprocess.call was being used incorrectly.

zoiba · March 15, 2011, 5:16pm

I can’t get packp3d works anymore, could this be related to your last update?

I got this error:

StandardError: Couldn't download import file.

here the file containing the full error message:
officinepixel.us/panda3d/pack3d_error.txt

I’ve tried deleting .panda3d directory from my home so to forcing reloading of all packaged but don’t changes anything.

many thanks

p.s. link fixed

rdb · March 15, 2011, 5:26pm

Your link is dead, but I think that your problem is the same as the one I’ve been hearing about from various people.

I found out I made a mistake in the way I built the 1.0.3 runtime, so I rebuilt it only a couple of hours ago and updated the download page with the updated 1.0.3 builds.

But I’m not sure if that actually fixed the problem.

rdb · March 15, 2011, 5:40pm

Actually, I don’t think that that is the problem. I think that _context is not supposed to be NULL at that point, it is supposed to already have been initialised by glxgsg::choose_pixel_format. So something in choose_pixel_format is going wrong, or it is not being called at all for some weird reason.

Unfortunately, everything works fine on my computer, so I cannot debug it here.

rdb · March 15, 2011, 8:53pm

OK, the contents.xml on runtime.panda3d.org had faulty hashes. It’s fixed now, so packp3d should work again.

zoiba · March 15, 2011, 9:12pm

I’m at home at the moment, it works fine here, tomorrow I’ll check it from work.
Thank you very much!

Nemesis_13 · March 16, 2011, 5:27pm

Maybe this helps you:
nopaste.info/cabc579e52.html

Bradamante · March 18, 2011, 11:13am

I tried that on a Mac. SPACE and then ENTER works, but I get this on the console:

DirectStart: Starting the game.
Known pipe types:
  osxGraphicsPipe
(all display modules loaded.)
1
:display:gsg:glgsg(error): at 4011 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2780 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 4011 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2780 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 4011 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2780 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 4011 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display:gsg:glgsg(error): at 2907 of panda/src/glstuff/glGraphicsStateGuardian_src.cxx : invalid operation
:display(error): Deactivating osxGraphicsStateGuardian.

When I do ENTER x-times and then SPACE once it works, SPACE a second time and it crashes with:

9
Traceback (most recent call last):
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/EventManager.py", line 61, in eventLoopTask
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/EventManager.py", line 55, in doEvents
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/EventManager.py", line 124, in processEvent
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/Messenger.py", line 388, in send
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/Messenger.py", line 473, in __dispatch
  File "/Applications/Panda3D_Mare_Ceti/ynjh_no_bug.py", line 39, in destroy
    self.buffer.clearRenderTextures()
AttributeError: 'NoneType' object has no attribute 'clearRenderTextures'
:task(error): Exception occurred in PythonTask eventManager
Traceback (most recent call last):
  File "/Applications/Panda3D_Mare_Ceti/ynjh_no_bug.py", line 68, in <module>
    run()
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/ShowBase.py", line 2630, in run
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/task/Task.py", line 502, in run
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/task/Task.py", line 460, in step
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/EventManager.py", line 61, in eventLoopTask
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/EventManager.py", line 55, in doEvents
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/EventManager.py", line 124, in processEvent
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/Messenger.py", line 388, in send
  File "dstroot/pythoncode/Developer/Panda3D/lib/direct/showbase/Messenger.py", line 473, in __dispatch
  File "/Applications/Panda3D_Mare_Ceti/ynjh_no_bug.py", line 39, in destroy
    self.buffer.clearRenderTextures()
AttributeError: 'NoneType' object has no attribute 'clearRenderTextures'